Skip to content

[VSC-1576] Add .gitignore when creating projects #1578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 3, 2025
Merged

[VSC-1576] Add .gitignore when creating projects #1578

merged 4 commits into from
Jul 3, 2025

Conversation

@radurentea
Copy link
Collaborator

@radurentea radurentea commented Jun 2, 2025

Description

Add .gitignore file when creating esp-idf projects

Fixes #1412

Type of change

  • New feature (non-breaking change which adds functionality)

Steps to test this pull request

Create a new esp-idf project. .gitignore should be added automatically with the content inside templates\.gitignore of this PR.

How has this been tested?

As described above

Test Configuration:

  • ESP-IDF Version: 5.4
  • OS (Windows,Linux and macOS): Windows

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@radurentea radurentea self-assigned this Jun 2, 2025
@github-actions
Copy link

github-actions bot commented Jun 2, 2025 •
edited
Loading

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

brianignacio5
brianignacio5 requested changes Jun 3, 2025
View reviewed changes
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change to reduce code duplication.

@radurentea radurentea added this to the v1.11.0 milestone Jun 3, 2025
@radurentea
Refactor implementation
626edac 
Added the code inside copyFromSrcProject
@radurentea radurentea requested a review from brianignacio5 June 4, 2025 13:35
@radurentea
Copy link
Collaborator Author

radurentea commented Jun 4, 2025

Small change to reduce code duplication.

Yes, you are right. I have changed the implementation.
Thank you!

@github-actions
Copy link

github-actions bot commented Jun 20, 2025

Pull request has been marked as stale since there are no activities, and this will be closed in 5 days if there are no further activities

@github-actions github-actions bot added the stale Stale PR or Issue label Jun 20, 2025
@radurentea radurentea removed the stale Stale PR or Issue label Jun 20, 2025
brianignacio5
brianignacio5 requested changes Jun 25, 2025
View reviewed changes
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some unrelated changes in this PR that could cause unexpected behavior.

@radurentea radurentea requested a review from brianignacio5 July 2, 2025 10:51
brianignacio5
brianignacio5 approved these changes Jul 3, 2025
View reviewed changes
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fabricio-ESP
Fabricio-ESP approved these changes Jul 3, 2025
View reviewed changes
Copy link
Collaborator

@Fabricio-ESP Fabricio-ESP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed gitignore file created from template successfully on new projects.

@radurentea radurentea merged commit 88c1c8d into master Jul 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianignacio5 brianignacio5 brianignacio5 approved these changes

@Fabricio-ESP Fabricio-ESP Fabricio-ESP approved these changes

Assignees

@radurentea radurentea

Labels

None yet

Projects

None yet

Milestone

v1.11.0

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Automatically Generate .gitignore for ESP-IDF Projects (VSC-1576)

4 participants

@radurentea @brianignacio5 @Fabricio-ESP